[Gretl-devel] Contribution to Gretl code (finnally :).

[Riccardo (Jack) Lucchetti]

On Thu, 7 Jun 2007, Hélio Guilherme wrote:

> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
>
> Dear Allin and Jack,
>
> Attached are my changes to modelprint.c, for the correct presenting of
> the p-values levels of acceptance legend, i.e. the * near the values.
>
> Please consider using that code or adapt to better style. I really think
> that the legend should appear.
>

Hélio,

thanks for your contribution. It's great having more people who contribute 
to the source. Welcome to the club!

That said, I have two remarks:

1) It's not necessary to include the modified C file. The diff file is 
enough. Besides, I prefer the unified diff format (diff -u), but maybe 
that's just personal.

2) I think that the legend should NOT appear. IMO, it clutters the output 
and provides no useful information to anyone that is just above the 
"absolute beginner" level. That said, I'm open to being convinced of 
the opposite. Hence, it's nice to have the code in, since it's simpler to 
#ifdef it out if one wants. Actually, we could have a "beginner" variable, 
which could be toggled on or off via a set command, to decide if one wants 
the kind of output that your patch provides. (In my view, this 
should be "off" by default.) Opinions on this, anyone?


Riccardo (Jack) Lucchetti
Dipartimento di Economia
Università Politecnica delle Marche

r.lucchetti at univpm.it
http://www.econ.univpm.it/lucchetti