[Gretl-devel] Bug in sort data menu entry

[Riccardo (Jack) Lucchetti]

On Mon, 22 Oct 2007, andreas.rosenblad at ltv.se wrote:

> A bug in the sort data menu entry:
>
> Using version 1.6.6pre2 build date 10/21/2007 on Windows XP and the data
> set Ramanathan data2-1: Selecting the menu entry Data > Sort data... to
> sort by vsat ascending, nothing changes. The data set is not sorted.
>
> However, by writing "dataset sortby vsat" in the gretl console the datset
> is sorted correctly.
>

The fix was very easy, and I just put it into CVS:

Index: gui2/library.c
===================================================================
RCS file: /cvsroot/gretl/gretl/gui2/library.c,v
retrieving revision 1.849
diff -u -w -u -r1.849 library.c
--- gui2/library.c      21 Oct 2007 15:11:07 -0000      1.849
+++ gui2/library.c      22 Oct 2007 09:35:59 -0000
@@ -5566,7 +5566,7 @@

         v = select_var_from_list_with_opt(list, "Select sort key",
                                           opts, DATASORT);
-       if (v > 1) {
+       if (v > 0) {
             err = dataset_sort_by(v, Z, datainfo, opt);
             if (err) {
                 gui_errmsg(err);


Riccardo (Jack) Lucchetti
Dipartimento di Economia
Università Politecnica delle Marche

r.lucchetti at univpm.it
http://www.econ.univpm.it/lucchetti